Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make profiling work with potel #3704

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Make profiling work with potel #3704

merged 1 commit into from
Oct 28, 2024

Conversation

sl0thentr0py
Copy link
Member

All profiling should work now except for the profiles_sampler config which will be handled separately.

image

@codecov Codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

❌ 2313 Tests Failed:

Tests completed Failed Passed Skipped
20409 2313 18096 4475
View the top 3 failed tests by shortest run time 
tests.integrations.litestar.test_litestar test_middleware_partial_receive_send
Stack Traces | 0s run time 
No failure message available

tests.integrations.litestar.test_litestar test_middleware_spans
Stack Traces | 0s run time 
No failure message available

tests.integrations.litestar.test_litestar test_span_origin
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

szokeasaurusrex
szokeasaurusrex approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we need to add tests, or should existing tests already cover these changes?

@sl0thentr0py
Copy link
Member Author

these PRs are about fixing existing CI, not adding new tests

@sl0thentr0py sl0thentr0py merged commit 2c26f42 into potel-base Oct 28, 2024
16 of 120 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/fix-profiling branch October 28, 2024 14:56
@sl0thentr0py sl0thentr0py mentioned this pull request Oct 28, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sl0thentr0py @szokeasaurusrex