Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(flags): rename launch darkly hook to match JS SDK #3743

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Nov 5, 2024

No description provided.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.94%. Comparing base (7022446) to head (22a190a).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3743      +/-   ##
==========================================
- Coverage   79.94%   79.94%   -0.01%     
==========================================
  Files         137      137              
  Lines       15421    15421              
  Branches     2614     2614              
==========================================
- Hits        12329    12328       -1     
  Misses       2223     2223              
- Partials      869      870       +1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/launchdarkly.py 79.48% <100.00%> (ø)

... and 1 file with indirect coverage changes

@antonpirker
Copy link
Member

@cmanallen is this fine with you?

@antonpirker
Copy link
Member

And @aliu39 is this ready for review, because it is a draft?

@aliu39 aliu39 marked this pull request as ready for review November 28, 2024 11:36
@aliu39 aliu39 enabled auto-merge (squash) November 28, 2024 11:41
@aliu39 aliu39 merged commit 65b1791 into master Nov 28, 2024
136 checks passed
@aliu39 aliu39 deleted the aliu/ld-hook-rename branch November 28, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants