Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom_sampling_context #3747

Merged
merged 18 commits into from
Nov 12, 2024

dropped result too

eb2df70
Select commit
Loading
Failed to load commit list.
Merged

Remove custom_sampling_context #3747

dropped result too
eb2df70
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 12, 2024 in 0s

25.60% (-51.98%) compared to 3f638f7

View this Pull Request on Codecov

25.60% (-51.98%) compared to 3f638f7

Details

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 25.60%. Comparing base (3f638f7) to head (eb2df70).

Files with missing lines Patch % Lines
sentry_sdk/integrations/opentelemetry/sampler.py 62.50% 2 Missing and 1 partial ⚠️
sentry_sdk/integrations/opentelemetry/scope.py 66.66% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3f638f7) and HEAD (eb2df70). Click for more details.

HEAD has 100 uploads less than BASE
Flag BASE (3f638f7) HEAD (eb2df70)
102 2
Additional details and impacted files
@@               Coverage Diff               @@
##           potel-base    #3747       +/-   ##
===============================================
- Coverage       77.58%   25.60%   -51.98%     
===============================================
  Files             139      139               
  Lines           14276    14270        -6     
  Branches         2242     2108      -134     
===============================================
- Hits            11076     3654     -7422     
- Misses           2520    10274     +7754     
+ Partials          680      342      -338     
Files with missing lines Coverage Δ
sentry_sdk/api.py 75.58% <100.00%> (-19.77%) ⬇️
sentry_sdk/integrations/opentelemetry/consts.py 100.00% <100.00%> (ø)
sentry_sdk/scope.py 48.09% <100.00%> (-34.00%) ⬇️
sentry_sdk/tracing.py 35.24% <100.00%> (-29.78%) ⬇️
sentry_sdk/integrations/opentelemetry/scope.py 64.55% <66.66%> (-31.65%) ⬇️
sentry_sdk/integrations/opentelemetry/sampler.py 52.50% <62.50%> (-39.29%) ⬇️

... and 116 files with indirect coverage changes