Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semantic attributes in traces sampler for ASGI spans #3774

Merged

Merge branch 'potel-base' into ivana/custom-sampling-context-integrat…

f674be1
Select commit
Loading
Failed to load commit list.
Merged

Use semantic attributes in traces sampler for ASGI spans #3774

Merge branch 'potel-base' into ivana/custom-sampling-context-integrat…
f674be1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 14, 2024 in 0s

25.55% (-50.15%) compared to e7218da

View this Pull Request on Codecov

25.55% (-50.15%) compared to e7218da

Details

Codecov Report

Attention: Patch coverage is 8.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 25.55%. Comparing base (e7218da) to head (f674be1).
Report is 37 commits behind head on potel-base.

Files with missing lines Patch % Lines
sentry_sdk/integrations/asgi.py 4.34% 22 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e7218da) and HEAD (f674be1). Click for more details.

HEAD has 101 uploads less than BASE
Flag BASE (e7218da) HEAD (f674be1)
102 1
Additional details and impacted files
@@               Coverage Diff               @@
##           potel-base    #3774       +/-   ##
===============================================
- Coverage       75.69%   25.55%   -50.15%     
===============================================
  Files             136      139        +3     
  Lines           14131    14302      +171     
  Branches         2225     2113      -112     
===============================================
- Hits            10697     3655     -7042     
- Misses           2794    10304     +7510     
+ Partials          640      343      -297     
Files with missing lines Coverage Δ
sentry_sdk/integrations/_asgi_common.py 16.66% <100.00%> (-77.78%) ⬇️
sentry_sdk/integrations/asgi.py 18.66% <4.34%> (-71.74%) ⬇️

... and 113 files with indirect coverage changes