Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote case for only_if_parent #3777

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

sl0thentr0py
Copy link
Member

No description provided.

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@sl0thentr0py sl0thentr0py merged commit 0011e22 into potel-base Nov 14, 2024
32 of 111 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/fix-only-remote branch November 14, 2024 14:46
Copy link

codecov bot commented Nov 14, 2024

❌ 1608 Tests Failed:

Tests completed Failed Passed Skipped
19831 1608 18223 4413
View the top 1 failed tests by shortest run time
tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-00:00-expected_output4]
Stack Traces | 0.001s run time
tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined
View the full list of 2 ❄️ flaky tests
tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-0000-expected_output6]

Flake rate in main: 58.44% (Passed 32 times, Failed 45 times)

Stack Traces | 0.001s run time
tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined
tests.test_scope test_with_isolation_scope_data

Flake rate in main: 99.14% (Passed 2 times, Failed 230 times)

Stack Traces | 0.001s run time
tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     
E     Full diff:
E     + {}
E     - {
E     -     'before_isolation_scope': 1,
E     - }

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants