Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_dsc and twp baggage handling #3789

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

sl0thentr0py
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 15, 2024

❌ 1198 Tests Failed:

Tests completed Failed Passed Skipped
19893 1198 18695 4413
View the top 1 failed tests by shortest run time
tests.integrations.opentelemetry.test_span_processor test_on_start_transaction
Stack Traces | 0.001s run time
.../integrations/opentelemetry/test_span_processor.py:289: in test_on_start_transaction
    fake_start_transaction,
.../hostedtoolcache/Python/3.7.17....../x64/lib/python3.7/unittest/mock.py:1307: in __enter__
    original, local = self.get_original()
.../hostedtoolcache/Python/3.7.17....../x64/lib/python3.7/unittest/mock.py:1281: in get_original
    "%s does not have the attribute %r" % (target, name)
E   AttributeError: <module 'sentry_sdk.integrations.opentelemetry.span_processor' from '.../integrations/opentelemetry/span_processor.py'> does not have the attribute 'start_transaction'
View the full list of 2 ❄️ flaky tests
tests.test_scope test_with_isolation_scope_data

Flake rate in main: 99.17% (Passed 2 times, Failed 239 times)

Stack Traces | 0.001s run time
tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     
E     Full diff:
E     + {}
E     - {
E     -     'before_isolation_scope': 1,
E     - }
tests.test_scope test_with_new_scope

Flake rate in main: 97.03% (Passed 8 times, Failed 261 times)

Stack Traces | 0.001s run time
tests/test_scope.py:587: in test_with_new_scope
    assert scope is in_with_current_scope
E   assert <PotelScope id=0x7fc7dc630130 name=None type=ScopeType.CURRENT> is <Scope id=0x7fc7dc6cd660 name=None type=ScopeType.CURRENT>

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@sl0thentr0py sl0thentr0py merged commit 5dc59d9 into neel/potel/fix-test-breadcrumbs Nov 18, 2024
45 of 125 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/fix-dsc branch November 18, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants