-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix httpx tests #3810
Fix httpx tests #3810
Conversation
❌ 622 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Just one small q.
assert "sentry-trace" in request_headers | ||
assert request_headers["sentry-trace"] == sentry_sdk.get_traceparent() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why we were expecting to not propagate in the original version of this test case? The updated behavior is what I'd have expected to always be the case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was part of this change
#3070
and I believe this was an unintended side effect of that change...
but now we fixed the span without transaction problem another way with only_if_parent
and this is the desired twp behaviour.
No description provided.