Fix rust tracing

[sl0thentr0py]

No description provided.

[sl0thentr0py]

@matt-codecov @antonpirker I simplified this part since we don't want users to do scope stuff in integrations, it is anti-patterny

[matt-codecov]

from a quick look at the code, it looks like __enter__() will still update the current span and keep track of the parent so that __exit__() can restore it, right? if so then i am fine with this. not qualified to stamp, and also CI is unhappy

[sl0thentr0py]

yes exactly, span management should be done in the core and will just work
ci is unhappy because this is a dev branch

[codecov]

❌ 922 Tests Failed:

Tests completed	Failed	Passed	Skipped
19684	922	18762	4424

View the top 2 failed tests by shortest run time

tests.integrations.opentelemetry.test_span_processor test_on_start_transaction

Stack Traces | 0.002s run time

.../integrations/opentelemetry/test_span_processor.py:287: in test_on_start_transaction
    with mock.patch(
.../hostedtoolcache/Python/3.12.7....../x64/lib/python3.12/unittest/mock.py:1463: in __enter__
    original, local = self.get_original()
.../hostedtoolcache/Python/3.12.7....../x64/lib/python3.12/unittest/mock.py:1436: in get_original
    raise AttributeError(
E   AttributeError: <module 'sentry_sdk.integrations.opentelemetry.span_processor' from '.../integrations/opentelemetry/span_processor.py'> does not have the attribute 'start_transaction'

tests.integrations.opentelemetry.test_span_processor test_on_start_transaction

Stack Traces | 0.002s run time

.../integrations/opentelemetry/test_span_processor.py:287: in test_on_start_transaction
    with mock.patch(
.../hostedtoolcache/Python/3.10.15....../x64/lib/python3.10/unittest/mock.py:1447: in __enter__
    original, local = self.get_original()
.../hostedtoolcache/Python/3.10.15....../x64/lib/python3.10/unittest/mock.py:1420: in get_original
    raise AttributeError(
E   AttributeError: <module 'sentry_sdk.integrations.opentelemetry.span_processor' from '.../integrations/opentelemetry/span_processor.py'> does not have the attribute 'start_transaction'

View the full list of 1 ❄️ flaky tests

tests.integrations.opentelemetry.test_span_processor test_on_start_transaction

Flake rate in main: 90.70% (Passed 4 times, Failed 39 times)

Stack Traces | 0.001s run time

.../integrations/opentelemetry/test_span_processor.py:289: in test_on_start_transaction
    fake_start_transaction,
.../hostedtoolcache/Python/3.7.17....../x64/lib/python3.7/unittest/mock.py:1307: in __enter__
    original, local = self.get_original()
.../hostedtoolcache/Python/3.7.17....../x64/lib/python3.7/unittest/mock.py:1281: in get_original
    "%s does not have the attribute %r" % (target, name)
E   AttributeError: <module 'sentry_sdk.integrations.opentelemetry.span_processor' from '.../integrations/opentelemetry/span_processor.py'> does not have the attribute 'start_transaction'

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

[matt-codecov]

PR title says "fix" - is this broken in 2.19?

also why does this need POtelSpan? to be clear, the Rust side of this is not OTEL

[sl0thentr0py]

this is a very large refactor of the SDK to use otel under the hood for the next major. And yes it's fine that the rust side is not otel.

You can ignore all the other stuff tbh, I just pinged you to take a look at the changes because I was changing your integration.

[matt-codecov]

oh interesting

the tracing framework has OTEL integrations in Rust, and there is a different project that actually can attach the Python OTEL context to a Rust function. do you expect that would Just Work and replace the need for this integration entirely?

[sl0thentr0py]

possibly! we can investigate that once we ship this and if it's feature compatible, we can remove it.

[sentrivana]

lgtm