Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix spans for streaming responses in WSGI based frameworks (#… #3836

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Dec 2, 2024

Reverts #3798

This reverts commit da20623.

Having a timer thread on each request is too much overhead on high volume servers.


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

@antonpirker antonpirker enabled auto-merge (squash) December 2, 2024 15:13
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.91%. Comparing base (6bd7e08) to head (0ac5be6).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/wsgi.py 93.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3836      +/-   ##
==========================================
- Coverage   79.95%   79.91%   -0.05%     
==========================================
  Files         137      137              
  Lines       15421    15385      -36     
  Branches     2614     2611       -3     
==========================================
- Hits        12330    12295      -35     
+ Misses       2223     2220       -3     
- Partials      868      870       +2     
Files with missing lines Coverage Δ
sentry_sdk/tracing_utils.py 84.03% <ø> (+0.10%) ⬆️
sentry_sdk/integrations/wsgi.py 84.82% <93.10%> (-1.14%) ⬇️

... and 4 files with indirect coverage changes

@antonpirker antonpirker merged commit 3d8445c into master Dec 2, 2024
136 checks passed
@antonpirker antonpirker deleted the antonpirker/revert-streaming-responses branch December 2, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants