Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): Replace release bot with GH app #3868

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Jeffreyhung
Copy link
Member

The getsentry-release is a GitHub bot account that is used in various automation, and the ${{ secrets.GH_RELEASE_PAT }} is a personal access token from that bot account. We are using a regular GitHub account as a bot while it should be a non-human account since there are no humans behind it. Hence, we are replacing it with a GitHub App.

Functionality wise, there will be no difference.

More details: https://www.notion.so/sentry/DACI-Replace-GitHub-bot-accounts-with-GitHub-Apps-getsentry-release-15109965d1204a91b9be71c49e8b66e0?pvs=4

#skip-changelog

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.97%. Comparing base (26479b2) to head (6311cb8).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3868      +/-   ##
==========================================
+ Coverage   79.93%   79.97%   +0.03%     
==========================================
  Files         137      137              
  Lines       15403    15403              
  Branches     2620     2620              
==========================================
+ Hits        12313    12319       +6     
+ Misses       2219     2212       -7     
- Partials      871      872       +1     

see 3 files with indirect coverage changes

@Jeffreyhung Jeffreyhung enabled auto-merge (squash) December 10, 2024 22:12
@Jeffreyhung Jeffreyhung requested a review from BYK December 10, 2024 23:52
@Jeffreyhung Jeffreyhung merged commit 6448c70 into master Dec 11, 2024
136 checks passed
@Jeffreyhung Jeffreyhung deleted the Replace-release-bot-with-GH-app branch December 11, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants