Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spotlight): Use the spotlight_url passed into the SDK when loading Spotlight #3871

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Dec 13, 2024

When we inject spotlight, we don't set the correct sidecar URL. This is an issue when a user defines a custom sidecar URL where we are able to load Spotlight UI from the correct URL but don't tell it the correct sidecar URL, making it non-functional.

…g Spotlight

When we inject spotlight, we don't set the correct sidecar URL. This is an issue when a user defines a custom sidecar URL where we are able to load Spotlight UI from the correct URL but don't tell it the correct sidecar URL, making it non-functional.
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just the formatting needs fixing since it's throwing a syntax error

sentry_sdk/spotlight.py Outdated Show resolved Hide resolved
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
@BYK BYK enabled auto-merge (squash) December 13, 2024 12:51
Copy link

codecov bot commented Dec 13, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
13825 2 13823 4130
View the top 2 failed tests by shortest run time
tests.integrations.stdlib.test_httplib test_http_timeout
Stack Traces | 20.2s run time
.../integrations/stdlib/test_httplib.py:373: in test_http_timeout
    assert len(transaction["spans"]) == 1
E   assert 0 == 1
E    +  where 0 = len([])
tests.integrations.stdlib.test_httplib test_http_timeout
Stack Traces | 20.2s run time
.../integrations/stdlib/test_httplib.py:373: in test_http_timeout
    assert len(transaction["spans"]) == 1
E   assert 0 == 1
E    +  where 0 = len([])

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@BYK BYK merged commit 81b8063 into master Dec 14, 2024
136 checks passed
@BYK BYK deleted the byk/fix/spotlight-url-django branch December 14, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants