fix(ci): update sample app build target to generic ios simulator (#4276)

getsentry · Nov 14, 2024 · e1ea4a8 · e1ea4a8
1 parent 57448c5
commit e1ea4a8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/.github/workflows/sample-application.yml b/.github/workflows/sample-application.yml
@@ -36,11 +36,9 @@ jobs:
         build-type: ['dev', 'production']
         include:
           - platform: ios
-            runs-on: macos-14 # uses m1 https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/
-            runtime: 'latest'
-            device: 'iPhone 14'
+            runs-on: macos-15
           - platform: macos
-            runs-on: macos-14
+            runs-on: macos-15
           - platform: android
             runs-on: ubuntu-latest
         exclude:
@@ -55,7 +53,10 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - run: corepack enable
+      - name: Enable Corepack
+        run: |
+          npm install -g corepack@0.29.4
+          corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: 18
@@ -132,7 +133,8 @@ jobs:
             -workspace sentryreactnativesample.xcworkspace \
             -configuration "$CONFIG" \
             -scheme sentryreactnativesample \
-            -destination 'platform=iOS Simulator,OS=${{ matrix.runtime }},name=${{ matrix.device }}' \
+            -sdk 'iphonesimulator' \
+            -destination 'generic/platform=iOS Simulator' \
             ONLY_ACTIVE_ARCH=yes \
             -derivedDataPath "$derivedData" \
             build \

diff --git a/samples/react-native/ios/sentryreactnativesample.xcodeproj/project.pbxproj b/samples/react-native/ios/sentryreactnativesample.xcodeproj/project.pbxproj
@@ -498,6 +498,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CLANG_ENABLE_MODULES = YES;
+				CODE_SIGN_IDENTITY = "Apple Development";
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
 				CODE_SIGN_STYLE = Manual;
 				CURRENT_PROJECT_VERSION = 1;
@@ -532,6 +533,7 @@
 			buildSettings = {
 				ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
 				CLANG_ENABLE_MODULES = YES;
+				CODE_SIGN_IDENTITY = "Apple Development";
 				"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
 				CODE_SIGN_STYLE = Manual;
 				CURRENT_PROJECT_VERSION = 1;