Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-dom dependency warning from using @sentry/react #1065

Closed
4 of 9 tasks
diegomais opened this issue Sep 10, 2020 · 1 comment · Fixed by #1354
Closed
4 of 9 tasks

react-dom dependency warning from using @sentry/react #1065

diegomais opened this issue Sep 10, 2020 · 1 comment · Fixed by #1354
Assignees
@jennmueng
Labels
Type: 🪲 Bug

Comments

@diegomais
Copy link

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

SDK:

  • @sentry/react-native (>= 1.0.0)
  • react-native-sentry (<= 0.43.2)

SDK version: 1.7.2

react-native version: 0.63.2

Are you using Expo?

  • Yes
  • No

I have following issue:

I receive the warning: "@sentry/react-native > @sentry/react@5.23.0" has unmet peer dependency "react-dom@15.x || 16.x".

Steps to reproduce:

  • Step 1 Run on terminal: yarn add @sentry/react-native
  • Step 2 Run on terminal: yarn audit

Actual result:

Warning message.

Expected result:

No warning message.
@jennmueng
Copy link
Member

Hi @diegomais! Thanks for the report, I've added it to our TODO to handle this.

@jennmueng jennmueng changed the title Dependency warning react-dom dependency warning from using @sentry/react Jan 4, 2021
This was referenced Feb 11, 2021
Closed
Merged
jennmueng added a commit that referenced this issue Feb 19, 2021
@jennmueng
build(js): Bump @sentry/* js dependencies to 6.20.0
906b86a 
Fixes react-dom dependency issues
Fixes #1065
jennmueng added a commit that referenced this issue Feb 19, 2021
@jennmueng
build(js): Bump @sentry/* js dependencies to 6.20.0
ffd93ab 
Fixes react-dom dependency issues
Fixes #1065
@jennmueng jennmueng mentioned this issue Feb 19, 2021
Merged
8 tasks
jennmueng added a commit that referenced this issue Feb 19, 2021
@jennmueng
build(js): Bump @sentry/* dependencies on javascript to 6.2.0 (#1354)
bbb0c13 
* build(js): Bump @sentry/* js dependencies to 6.20.0

Fixes react-dom dependency issues
Fixes #1065

* meta: Changelog

* meta: 6.2.0 in changelog not 6.20.0
@github-actions github-actions bot mentioned this issue Jul 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennmueng jennmueng

Labels
Type: 🪲 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(js): Bump @sentry/* dependencies on javascript to 6.2.0 getsentry/sentry-react-native
2 participants
@jennmueng @diegomais