-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(debug): Symbolicate message and non-Error stacktraces locally #3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0bf494+dirty | 1289.40 ms | 1298.40 ms | 9.00 ms |
3853f43+dirty | 1221.82 ms | 1242.64 ms | 20.82 ms |
e73f4ed+dirty | 1243.27 ms | 1244.52 ms | 1.25 ms |
9c48b2c+dirty | 1246.96 ms | 1255.73 ms | 8.77 ms |
27ef4ee+dirty | 1293.52 ms | 1296.08 ms | 2.56 ms |
6e8584e+dirty | 1274.50 ms | 1296.82 ms | 22.32 ms |
acadc0f+dirty | 1264.38 ms | 1290.06 ms | 25.68 ms |
8900e1a+dirty | 1210.27 ms | 1218.66 ms | 8.39 ms |
e2b64fe+dirty | 1232.22 ms | 1255.20 ms | 22.98 ms |
e5c9b8b+dirty | 1258.57 ms | 1267.32 ms | 8.75 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0bf494+dirty | 2.36 MiB | 2.83 MiB | 481.15 KiB |
3853f43+dirty | 2.36 MiB | 2.85 MiB | 499.81 KiB |
e73f4ed+dirty | 2.36 MiB | 2.82 MiB | 469.44 KiB |
9c48b2c+dirty | 2.36 MiB | 2.85 MiB | 495.77 KiB |
27ef4ee+dirty | 2.36 MiB | 2.85 MiB | 500.03 KiB |
6e8584e+dirty | 2.36 MiB | 2.88 MiB | 533.17 KiB |
acadc0f+dirty | 2.36 MiB | 2.83 MiB | 480.37 KiB |
8900e1a+dirty | 2.36 MiB | 2.83 MiB | 479.25 KiB |
e2b64fe+dirty | 2.36 MiB | 2.85 MiB | 495.80 KiB |
e5c9b8b+dirty | 2.36 MiB | 2.87 MiB | 520.43 KiB |
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5c9b8b | 409.02 ms | 426.66 ms | 17.64 ms |
d0bf494+dirty | 375.37 ms | 395.14 ms | 19.77 ms |
575f9da | 415.26 ms | 422.98 ms | 7.72 ms |
0db0c72 | 372.12 ms | 386.00 ms | 13.88 ms |
e73f4ed+dirty | 332.96 ms | 354.33 ms | 21.37 ms |
acadc0f+dirty | 373.24 ms | 381.51 ms | 8.27 ms |
8900e1a+dirty | 430.68 ms | 456.13 ms | 25.44 ms |
3ffcddd | 302.92 ms | 315.80 ms | 12.88 ms |
d361d38 | 354.10 ms | 381.69 ms | 27.59 ms |
f06c879 | 408.41 ms | 424.54 ms | 16.13 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5c9b8b | 17.73 MiB | 19.83 MiB | 2.10 MiB |
d0bf494+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
575f9da | 17.73 MiB | 19.83 MiB | 2.10 MiB |
0db0c72 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
e73f4ed+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
acadc0f+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
8900e1a+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
3ffcddd | 17.73 MiB | 19.75 MiB | 2.02 MiB |
d361d38 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
f06c879 | 17.73 MiB | 19.85 MiB | 2.12 MiB |
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0bf494+dirty | 253.73 ms | 308.23 ms | 54.49 ms |
3853f43+dirty | 278.12 ms | 338.72 ms | 60.60 ms |
e73f4ed+dirty | 262.98 ms | 311.02 ms | 48.04 ms |
9c48b2c+dirty | 270.82 ms | 321.12 ms | 50.30 ms |
27ef4ee+dirty | 296.71 ms | 351.00 ms | 54.29 ms |
6e8584e+dirty | 383.37 ms | 400.84 ms | 17.47 ms |
acadc0f+dirty | 259.04 ms | 304.67 ms | 45.63 ms |
8900e1a+dirty | 371.40 ms | 377.70 ms | 6.31 ms |
e2b64fe+dirty | 258.82 ms | 304.26 ms | 45.44 ms |
e5c9b8b+dirty | 335.40 ms | 360.06 ms | 24.67 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0bf494+dirty | 7.15 MiB | 8.04 MiB | 910.85 KiB |
3853f43+dirty | 7.15 MiB | 8.08 MiB | 959.34 KiB |
e73f4ed+dirty | 7.15 MiB | 8.09 MiB | 965.94 KiB |
9c48b2c+dirty | 7.15 MiB | 8.07 MiB | 947.16 KiB |
27ef4ee+dirty | 7.15 MiB | 8.08 MiB | 959.49 KiB |
6e8584e+dirty | 7.15 MiB | 8.13 MiB | 1002.18 KiB |
acadc0f+dirty | 7.15 MiB | 8.03 MiB | 903.20 KiB |
8900e1a+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
e2b64fe+dirty | 7.15 MiB | 8.07 MiB | 947.16 KiB |
e5c9b8b+dirty | 7.15 MiB | 8.10 MiB | 980.41 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0bf494+dirty | 1266.20 ms | 1267.52 ms | 1.32 ms |
3853f43+dirty | 1271.74 ms | 1278.04 ms | 6.30 ms |
e73f4ed+dirty | 1282.90 ms | 1309.30 ms | 26.40 ms |
9c48b2c+dirty | 1253.39 ms | 1256.30 ms | 2.91 ms |
27ef4ee+dirty | 1236.41 ms | 1244.90 ms | 8.49 ms |
6e8584e+dirty | 1271.71 ms | 1281.26 ms | 9.55 ms |
acadc0f+dirty | 1271.12 ms | 1272.28 ms | 1.16 ms |
8900e1a+dirty | 1268.36 ms | 1273.04 ms | 4.68 ms |
e2b64fe+dirty | 1285.78 ms | 1297.56 ms | 11.78 ms |
e5c9b8b+dirty | 1276.90 ms | 1280.92 ms | 4.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0bf494+dirty | 2.92 MiB | 3.40 MiB | 488.08 KiB |
3853f43+dirty | 2.92 MiB | 3.41 MiB | 503.54 KiB |
e73f4ed+dirty | 2.92 MiB | 3.38 MiB | 475.71 KiB |
9c48b2c+dirty | 2.92 MiB | 3.41 MiB | 499.97 KiB |
27ef4ee+dirty | 2.92 MiB | 3.41 MiB | 503.72 KiB |
6e8584e+dirty | 2.92 MiB | 3.44 MiB | 536.52 KiB |
acadc0f+dirty | 2.92 MiB | 3.39 MiB | 487.34 KiB |
8900e1a+dirty | 2.92 MiB | 3.39 MiB | 485.96 KiB |
e2b64fe+dirty | 2.92 MiB | 3.41 MiB | 499.97 KiB |
e5c9b8b+dirty | 2.92 MiB | 3.43 MiB | 524.50 KiB |
lucas-zimerman
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR fixes local symbolication in debug mode.
Before this PR captured non-Error exceptions (strings, number, objects) would result in missing stack trace.
Before this PR stack trace attached to the captured message would be minified.
This PR removes checks for RN below 0.65 as the SDK doesn't work on those since v5.
This PR adds integration tests with mocked current React Native dev tools responses.
💡 Motivation and Context
💚 How did you test it?
sample app
debug app unhandled rejection without stack trace before this PR -> https://sentry-sdks.sentry.io/issues/4665930607/events/f654a00e277a4dd48916c0c9d2113471/
debug unhandled rejection without stack trace after this PR -> https://sentry-sdks.sentry.io/issues/4666187537/events/04f82d0b70de49acaec61038a00a5e39/
debug app capture message before this PR -> https://sentry-sdks.sentry.io/issues/4665887083/events/190f198eee234da0884fe2b69ae2742e/
debug app capture message after this PR -> https://sentry-sdks.sentry.io/issues/4666389286/events/e4f3c35e1a24460e9fe595563da5049b/
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps