Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expo): read .env file in upload script #3571

Merged
merged 6 commits into from
Jan 31, 2024

Conversation

quinlanj
Copy link
Contributor

@quinlanj quinlanj commented Jan 30, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Read from .env file if it exists in the user's project directory, based on #3546 (comment)

Fixes #3569

Most of the expo commands are of this form:

  1. Set NODE_ENV to development if unset (unless if the command is expo export, where the metro bundler will output differently depending on NODE_ENV so we default it to production)
  2. Read from .env file - @expo/env is a dependency of the expo/cli so we make a best effort to load it at runtime.

💡 Motivation and Context

💚 How did you test it?

test project

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@krystofwoldrich krystofwoldrich changed the title feat(expo) read .env file in upload script feat(expo): read .env file in upload script Jan 30, 2024
quinlanj and others added 2 commits January 30, 2024 15:23
Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good. 🚀

@krystofwoldrich krystofwoldrich merged commit a588df8 into getsentry:main Jan 31, 2024
24 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sentry-expo-upload-sourcemaps read ENV files
2 participants