-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update Cocoa SDK to v8.38.0 #4180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
krystofwoldrich,
lucas-zimerman and
antonis
as code owners
October 15, 2024 14:05
github-actions
bot
added
the
dependencies
Pull requests that update a dependency file
label
Oct 15, 2024
bruno-garcia
force-pushed
the
deps/scripts/update-cocoa.sh
branch
from
October 15, 2024 14:05
e916c97
to
64c7c00
Compare
bruno-garcia
force-pushed
the
deps/scripts/update-cocoa.sh
branch
from
October 15, 2024 14:14
64c7c00
to
4d42e3d
Compare
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e73d82f | 475.82 ms | 506.55 ms | 30.73 ms |
0ebca77 | 414.93 ms | 444.49 ms | 29.56 ms |
484813b | 434.55 ms | 452.31 ms | 17.75 ms |
e540498 | 436.26 ms | 433.00 ms | -3.26 ms |
acadc0f+dirty | 373.24 ms | 381.51 ms | 8.27 ms |
70e6261 | 482.65 ms | 495.70 ms | 13.05 ms |
b1e8712 | 462.11 ms | 465.71 ms | 3.60 ms |
0677344 | 327.74 ms | 337.14 ms | 9.40 ms |
3ffcddd | 302.92 ms | 315.80 ms | 12.88 ms |
728164b | 414.34 ms | 449.22 ms | 34.88 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e73d82f | 17.73 MiB | 20.07 MiB | 2.33 MiB |
0ebca77 | 17.73 MiB | 19.95 MiB | 2.21 MiB |
484813b | 17.73 MiB | 20.07 MiB | 2.33 MiB |
e540498 | 17.73 MiB | 20.11 MiB | 2.37 MiB |
acadc0f+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
70e6261 | 17.73 MiB | 19.94 MiB | 2.21 MiB |
b1e8712 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
0677344 | 17.73 MiB | 19.81 MiB | 2.07 MiB |
3ffcddd | 17.73 MiB | 19.75 MiB | 2.02 MiB |
728164b | 17.73 MiB | 19.85 MiB | 2.12 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5c9b8b+dirty | 1258.57 ms | 1267.32 ms | 8.75 ms |
0db0c72+dirty | 1275.02 ms | 1285.84 ms | 10.82 ms |
76d1baf+dirty | 1244.10 ms | 1268.52 ms | 24.42 ms |
1c65324+dirty | 1235.17 ms | 1235.08 ms | -0.09 ms |
e2b64fe+dirty | 1232.22 ms | 1255.20 ms | 22.98 ms |
8900e1a+dirty | 1210.27 ms | 1218.66 ms | 8.39 ms |
5571a20+dirty | 1203.57 ms | 1204.57 ms | 1.00 ms |
e73f4ed+dirty | 1243.27 ms | 1244.52 ms | 1.25 ms |
e73d82f+dirty | 1207.52 ms | 1216.73 ms | 9.21 ms |
d7401ac+dirty | 1252.38 ms | 1275.04 ms | 22.66 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5c9b8b+dirty | 2.36 MiB | 2.87 MiB | 520.43 KiB |
0db0c72+dirty | 2.36 MiB | 2.84 MiB | 487.01 KiB |
76d1baf+dirty | 2.36 MiB | 2.82 MiB | 469.45 KiB |
1c65324+dirty | 2.36 MiB | 3.04 MiB | 698.64 KiB |
e2b64fe+dirty | 2.36 MiB | 2.85 MiB | 495.80 KiB |
8900e1a+dirty | 2.36 MiB | 2.83 MiB | 479.25 KiB |
5571a20+dirty | 2.36 MiB | 2.92 MiB | 569.93 KiB |
e73f4ed+dirty | 2.36 MiB | 2.82 MiB | 469.44 KiB |
e73d82f+dirty | 2.36 MiB | 3.08 MiB | 734.23 KiB |
d7401ac+dirty | 2.36 MiB | 2.83 MiB | 481.14 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5c9b8b+dirty | 1276.90 ms | 1280.92 ms | 4.02 ms |
0db0c72+dirty | 1258.88 ms | 1262.52 ms | 3.64 ms |
76d1baf+dirty | 1245.00 ms | 1257.76 ms | 12.76 ms |
1c65324+dirty | 1239.71 ms | 1239.86 ms | 0.15 ms |
e2b64fe+dirty | 1285.78 ms | 1297.56 ms | 11.78 ms |
8900e1a+dirty | 1268.36 ms | 1273.04 ms | 4.68 ms |
5571a20+dirty | 1228.09 ms | 1233.45 ms | 5.36 ms |
e73f4ed+dirty | 1282.90 ms | 1309.30 ms | 26.40 ms |
e73d82f+dirty | 1231.20 ms | 1228.81 ms | -2.40 ms |
d7401ac+dirty | 1288.10 ms | 1289.54 ms | 1.44 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5c9b8b+dirty | 2.92 MiB | 3.43 MiB | 524.50 KiB |
0db0c72+dirty | 2.92 MiB | 3.40 MiB | 492.71 KiB |
76d1baf+dirty | 2.92 MiB | 3.38 MiB | 475.74 KiB |
1c65324+dirty | 2.92 MiB | 3.61 MiB | 705.56 KiB |
e2b64fe+dirty | 2.92 MiB | 3.41 MiB | 499.97 KiB |
8900e1a+dirty | 2.92 MiB | 3.39 MiB | 485.96 KiB |
5571a20+dirty | 2.92 MiB | 3.48 MiB | 575.54 KiB |
e73f4ed+dirty | 2.92 MiB | 3.38 MiB | 475.71 KiB |
e73d82f+dirty | 2.92 MiB | 3.64 MiB | 740.56 KiB |
d7401ac+dirty | 2.92 MiB | 3.40 MiB | 488.06 KiB |
antonis
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I've already used the beta.1
without issues in #4124.
Restraining from merging till v6
release is concluded.
@krystofwoldrich do we want the new cocoa version in the release?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps scripts/update-cocoa.sh from 8.37.0 to 8.38.0.
Auto-generated by a dependency updater.
Changelog
8.38.0
8.38.0-beta.1
Features
Improvements
redact
options and APIs tomask
(#4373)Fixes
via the option
swizzleClassNameExclude
.