Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Skip maestro test if SENTRY_AUTH_TOKEN is unavailable or empty #4288

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(ci): Skip maestro test if SENTRY_AUTH_TOKEN is unavailable or empty #4288

merged 1 commit into from
Nov 19, 2024

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Nov 18, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Skip maestro test if SENTRY_AUTH_TOKEN is unavailable or empty

💡 Motivation and Context

This is an additional fix after #4269 since the CI issue was not solved #4284 (comment)

💚 How did you test it?

CI

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@antonis antonis mentioned this pull request Nov 18, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 435.00 ms 429.08 ms -5.92 ms
Size 17.74 MiB 20.08 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
fe13591 478.92 ms 480.84 ms 1.92 ms
4cc5c27 460.04 ms 496.32 ms 36.28 ms
cdf2f33 469.46 ms 462.17 ms -7.29 ms
d43a46b 454.22 ms 477.79 ms 23.57 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
5a22220 412.38 ms 447.35 ms 34.97 ms
d0bf494+dirty 375.37 ms 395.14 ms 19.77 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
0d3e677 422.82 ms 411.90 ms -10.92 ms

App size

Revision Plain With Sentry Diff
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
fe13591 17.74 MiB 20.07 MiB 2.34 MiB
4cc5c27 17.73 MiB 19.95 MiB 2.21 MiB
cdf2f33 17.74 MiB 20.08 MiB 2.34 MiB
d43a46b 17.73 MiB 20.06 MiB 2.33 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
5a22220 17.73 MiB 19.93 MiB 2.20 MiB
d0bf494+dirty 17.73 MiB 19.75 MiB 2.02 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
0d3e677 17.74 MiB 20.07 MiB 2.34 MiB

@github-actions GitHub Actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 414.80 ms 462.75 ms 47.95 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
2ec71da+dirty 375.64 ms 431.59 ms 55.95 ms
8c88ac7+dirty 402.72 ms 434.32 ms 31.60 ms
728164b+dirty 335.93 ms 342.94 ms 7.01 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
d0bf494+dirty 253.73 ms 308.23 ms 54.49 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
e540498+dirty 408.56 ms 480.00 ms 71.44 ms
c639edf+dirty 363.39 ms 414.78 ms 51.39 ms
6e8584e+dirty 383.37 ms 400.84 ms 17.47 ms

App size

Revision Plain With Sentry Diff
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
2ec71da+dirty 7.15 MiB 8.38 MiB 1.23 MiB
8c88ac7+dirty 7.15 MiB 8.35 MiB 1.20 MiB
728164b+dirty 7.15 MiB 8.12 MiB 997.71 KiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
d0bf494+dirty 7.15 MiB 8.04 MiB 910.85 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
e540498+dirty 7.15 MiB 8.38 MiB 1.23 MiB
c639edf+dirty 7.15 MiB 8.35 MiB 1.20 MiB
6e8584e+dirty 7.15 MiB 8.13 MiB 1002.18 KiB

@github-actions GitHub Actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.62 ms 1217.27 ms -0.35 ms
Size 2.36 MiB 3.10 MiB 753.04 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
457e29f+dirty 1253.94 ms 1269.18 ms 15.24 ms
d43a46b+dirty 1219.24 ms 1219.65 ms 0.41 ms
e5bc97b+dirty 1230.63 ms 1234.83 ms 4.20 ms
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
c639edf+dirty 1236.18 ms 1235.04 ms -1.14 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms
52c0562+dirty 1219.34 ms 1221.25 ms 1.91 ms
5446992+dirty 1273.28 ms 1276.68 ms 3.40 ms
0677344+dirty 1276.70 ms 1300.07 ms 23.37 ms
8ae23a7+dirty 1230.02 ms 1227.62 ms -2.40 ms

App size

Revision Plain With Sentry Diff
457e29f+dirty 2.36 MiB 2.87 MiB 520.67 KiB
d43a46b+dirty 2.36 MiB 3.08 MiB 734.25 KiB
e5bc97b+dirty 2.36 MiB 3.10 MiB 753.14 KiB
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
c639edf+dirty 2.36 MiB 3.08 MiB 736.63 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB
52c0562+dirty 2.36 MiB 3.14 MiB 793.36 KiB
5446992+dirty 2.36 MiB 2.88 MiB 531.94 KiB
0677344+dirty 2.36 MiB 2.85 MiB 496.81 KiB
8ae23a7+dirty 2.36 MiB 3.10 MiB 752.42 KiB

@github-actions GitHub Actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.91 ms 1232.16 ms -1.75 ms
Size 2.92 MiB 3.66 MiB 757.49 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
457e29f+dirty 1256.71 ms 1258.50 ms 1.79 ms
d43a46b+dirty 1223.31 ms 1230.92 ms 7.61 ms
e5bc97b+dirty 1229.17 ms 1227.64 ms -1.54 ms
9c48b2c+dirty 1253.39 ms 1256.30 ms 2.91 ms
c639edf+dirty 1223.63 ms 1227.98 ms 4.35 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms
52c0562+dirty 1233.94 ms 1226.29 ms -7.65 ms
5446992+dirty 1249.94 ms 1254.80 ms 4.86 ms
0677344+dirty 1252.52 ms 1254.08 ms 1.56 ms
8ae23a7+dirty 1233.67 ms 1229.52 ms -4.15 ms

App size

Revision Plain With Sentry Diff
457e29f+dirty 2.92 MiB 3.43 MiB 524.75 KiB
d43a46b+dirty 2.92 MiB 3.64 MiB 740.29 KiB
e5bc97b+dirty 2.92 MiB 3.66 MiB 758.40 KiB
9c48b2c+dirty 2.92 MiB 3.41 MiB 499.97 KiB
c639edf+dirty 2.92 MiB 3.64 MiB 742.55 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB
52c0562+dirty 2.92 MiB 3.69 MiB 794.15 KiB
5446992+dirty 2.92 MiB 3.44 MiB 535.26 KiB
0677344+dirty 2.92 MiB 3.41 MiB 500.94 KiB
8ae23a7+dirty 2.92 MiB 3.66 MiB 757.67 KiB

krystofwoldrich
krystofwoldrich approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@antonis antonis merged commit 77680ec into main Nov 19, 2024
63 checks passed
@antonis antonis deleted the antonis/skip-maestro-nosentrytoken-2 branch November 19, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonis @krystofwoldrich