feat: Add local source context via devserver #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobsterkatie
reviewed
Jan 9, 2020
| function: frame.methodName, | ||
| in_app: inApp, | ||
| lineno: inApp ? frame.lineNumber : undefined, // :HACK | ||
| platform: inApp ? "javascript" : "node" // :HACK |
There was a problem hiding this comment.
Given that we're now filtering out both node modules and native code, would it be better to make the default undefined? Or to test for frame.file.includes("native code") also, and if it fails both the inApp test and the native code test, then have it default to node?
lobsterkatie
reviewed
Jan 9, 2020
|
I've refactored the code in our code packages since we had this functionality already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.