Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use new Android SDK #749

Merged
merged 10 commits into from
Feb 12, 2020
Merged

feat: Use new Android SDK #749

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
881ec30
feat: Capture Envelope, new Android SDK
HazAT Jan 24, 2020
688ae14
fix: BeforeSend
HazAT Jan 27, 2020
b3c42d0
ref: Checks in Java
HazAT Jan 28, 2020
3bd8482
Merge branch 'master' into feat/new-android-sdk
HazAT Feb 5, 2020
2874dcd
fix: Release identifer
HazAT Feb 5, 2020
2bf31bf
fix: Re-enable breacrumbs integration
HazAT Feb 11, 2020
23d75f6
meta: Bump dependecies
HazAT Feb 11, 2020
ccc5569
ref: Remove example, Remove travis tests
HazAT Feb 11, 2020
6383a8c
ci: Update
HazAT Feb 11, 2020
4291f01
meta: Changelog
HazAT Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,26 @@ android {
}

defaultConfig {
minSdkVersion safeExtGet('minSdkVersion', 16)
minSdkVersion safeExtGet('minSdkVersion', 21)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're aiming API 18 on sentry-android-ndk. For sentry-android only it's API 14

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may keep 16, and do this on manifest -> https://github.com/getsentry/sentry-android/blob/fd6413b92ed97efdecccc1fa6d8abef27fb1c816/sentry-sample/src/main/AndroidManifest.xml#L7

so you support non-ndk from 16 to 20 and with ndk support from 21 on

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changes needed on manifest, minSdkVersion=16 just works :)

targetSdkVersion safeExtGet('targetSdkVersion', 26)
versionCode 1
versionName "1.0"
ndk {
abiFilters "armeabi-v7a", "x86"
}
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}

lintOptions {
warning 'InvalidPackage'
}
}

dependencies {
implementation 'com.facebook.react:react-native:+'
implementation 'io.sentry:sentry-android:1.7.29'
implementation 'io.sentry:sentry-android:2+'
HazAT marked this conversation as resolved.
Show resolved Hide resolved
}
3 changes: 3 additions & 0 deletions android/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,7 @@
package="io.sentry">
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
<application>
<meta-data android:name="io.sentry.auto-init" android:value="false" />
</application>
</manifest>
128 changes: 0 additions & 128 deletions android/src/main/java/io/sentry/ArrayUtil.java
View file
Open in desktop

This file was deleted.

134 changes: 0 additions & 134 deletions android/src/main/java/io/sentry/MapUtil.java
View file
Open in desktop

This file was deleted.

Loading