fix: Serialize the default user keys in setUser #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😅 |
bruno-garcia
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Passes the default user keys to the serialization helper before passing it to native.
💡 Motivation and Context
Users would be able to use non-strings such as ints or doubles as user ids or in any other default user field.
Fixes #922
💚 How did you test it?
Tested by passing
3.14159265359as a user id on both Android and iOS, performed native crashes and assured that the user is correct on the Sentry dashboard.Also added a test that
setUserserializes all object keys and splits into a second data object.📝 Checklist
🔮 Next steps