Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LogBox instead of YellowBox in RN 0.63 + Update sample app to RN 0.63.1 #989

Merged
merged 11 commits into from
Jul 23, 2020

Conversation

jennmueng
Copy link
Member

@jennmueng jennmueng commented Jul 21, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Use LogBox in backend.ts if it exists, otherwise fallback to older YellowBox. Also updates the sample app to 0.63.

💡 Motivation and Context

In React Native 0.63 YellowBox is deprecated and replaced with LogBox. Using the SDK in 0.63 shows annoying warnings: #977

💚 How did you test it?

Tested on Sample App running on both 0.62.2 and 0.63.1

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

YellowBox is deprecated in RN 0.63 and replaced with LogBox.
But we check for it and fall back to Yellowbox to support older versions
@jennmueng jennmueng linked an issue Jul 21, 2020 that may be closed by this pull request
src/js/backend.ts Outdated Show resolved Hide resolved
jennmueng and others added 5 commits July 21, 2020 18:45
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Otherwise the app doesn't open and shows a white screen
@jennmueng jennmueng merged commit b706722 into master Jul 23, 2020
@jennmueng jennmueng deleted the rn-0.63-update branch July 23, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RN 0.63.1] LogBox should be used instead of YellowBox (WARNING)
3 participants