fix: don't initiate DeviceContext if enableNative is false

[cruzach]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

DeviceContext calls into native, which can result in extraneous error logs if the user has already stated they don't want to enable the native SDK.
I also silenced the console warning if enableNativeNagger is false

💡 Motivation and Context

This is an issue for our integration of sentry-expo expo/sentry-expo#120

💚 How did you test it?

Ran yarn test and tested in an expo project with sentry, no more bad logs! 🎉

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• All tests passing
• No breaking changes

🔮 Next steps

[bruno-garcia]

Thanks for the fix

[luizjr]

Congratulations on the correction.
I would like to know when it will be available in the repository:
https://github.com/expo/sentry-expo

[lukebars]

Looks like you have to specify enableNative: true, else it will be false now?

[cruzach]

@lukebars I don't think so. It should default to true

[lukebars]

@cruzach hmm, I've tried to send example crash to Sentry without specifying enableNative: true and DeviceContext was completely empty...

[cruzach]

Oh you're right, I assigned default options after that deviceContext check 🤦

In sdk.ts:

if (options.enableNative) {
      options.defaultIntegrations.push(new DeviceContext());
}
options = assignDefaultOptions(options);

should be

options = assignDefaultOptions(options);
if (options.enableNative) {
      options.defaultIntegrations.push(new DeviceContext());
}

[bruno-garcia]

Looks like we have no tests for that eh :/