Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Delayed::Job instance in hint #1861

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Aug 2, 2022

It would be useful to include the Delayed::Job instance in hint, so it can be used for filtering in before_send.

@c960657 c960657 changed the title Include Delayed::Job instance in hints Include Delayed::Job instance in hint Aug 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...entry-delayed_job/lib/sentry/delayed_job/plugin.rb 100.00% <100.00%> (ø)

... and 112 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@st0012
Copy link
Collaborator

st0012 commented Sep 27, 2022

Sorry for the delay. I think this is helpful but may cause issue with the async option, which we plan to drop in v6.0.0.
I'll revisit this after it's dropped.

@st0012 st0012 modified the milestones: 5.5.0, 6.0.0 Oct 7, 2022
@getsantry
Copy link

getsantry bot commented Oct 18, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants