Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop IRB's patch #2104

Merged
merged 2 commits into from
Sep 10, 2023
Merged

Drop IRB's patch #2104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2677f3
Revert "Pin irb to 1.7.4 for ruby 2.7 / rails 6.0.0 (#2097)"
st0012 Sep 8, 2023
29ef7fc
Lock psych version to fit older Rails versions
st0012 Sep 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions sentry-rails/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ if rails_version > Gem::Version.new("7.0.0")
gem "rails", github: "rails/rails"
else
gem "rails", "~> #{rails_version}"
gem "psych", "~> 3.0.0"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because Rails 6 doesn't require psych's version, it could still be bumped to a incompatible version. So we need to lock it here.

end

gem "mini_magick"
Expand All @@ -47,12 +48,7 @@ gem "rake", "~> 12.0"

if RUBY_VERSION.to_f >= 2.6
gem "debug", github: "ruby/debug", platform: :ruby

if rails_version == Gem::Version.new("6.0.0") && RUBY_VERSION.to_f == 2.7
gem "irb", "~> 1.7.4" # irb 1.8 adds psych via rdoc that causes CI to fail
else
gem "irb"
end
gem "irb"
end

gem "pry"
Expand Down