Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up config.cron.default_timezone from Rails config #2213

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Dec 31, 2023

Since Rails apps should have their timezone set, I think we can pick up config.cron.default_timezone from it.

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Merging #2213 (a2f945e) into master (babdd55) will increase coverage by 30.89%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2213       +/-   ##
===========================================
+ Coverage   66.48%   97.38%   +30.89%     
===========================================
  Files         100      102        +2     
  Lines        3742     3818       +76     
===========================================
+ Hits         2488     3718     +1230     
+ Misses       1254      100     -1154     
Components Coverage Δ
sentry-ruby 98.07% <ø> (+42.16%) ⬆️
sentry-rails 95.01% <100.00%> (+0.03%) ⬆️
sentry-sidekiq 94.70% <ø> (ø)
sentry-resque 92.06% <ø> (ø)
sentry-delayed_job 94.44% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-rails/lib/sentry/rails/railtie.rb 98.75% <100.00%> (+0.06%) ⬆️

... and 55 files with indirect coverage changes

@st0012 st0012 force-pushed the pickup-cron-default-for-rails-apps branch from 1094b02 to a2f945e Compare January 1, 2024 12:53
@st0012 st0012 merged commit 3ea9e79 into master Jan 2, 2024
109 of 123 checks passed
@st0012 st0012 deleted the pickup-cron-default-for-rails-apps branch January 2, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants