Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sqlite3 for building gems #2222

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jan 9, 2024

closes #2221

new sqlite3 release 1.7.0 dropped support for ruby < 3.0, so building sentry-rails and sentry-delayed_job failed silently and only the rest were released by craft.

#skip-changelog

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-release-sqqlite branch from 0bb00f6 to 6de2cd4 Compare January 9, 2024 13:43
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #2222 (c1b5e88) into master (15f027e) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2222      +/-   ##
==========================================
- Coverage   97.44%   97.42%   -0.03%     
==========================================
  Files         102      102              
  Lines        3801     3801              
==========================================
- Hits         3704     3703       -1     
- Misses         97       98       +1     
Components Coverage Δ
sentry-ruby 98.13% <ø> (ø)
sentry-rails 95.01% <ø> (ø)
sentry-sidekiq 94.70% <ø> (ø)
sentry-resque 92.06% <ø> (-1.59%) ⬇️
sentry-delayed_job 94.44% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)

see 1 file with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-release-sqqlite branch from 6de2cd4 to c1b5e88 Compare January 9, 2024 13:57
@sl0thentr0py sl0thentr0py merged commit b0f0ead into master Jan 9, 2024
122 of 123 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-release-sqqlite branch January 9, 2024 14:07
@st0012
Copy link
Collaborator

st0012 commented Jan 13, 2024

Is #2224 the craft upgrade needed to revert these changes?

@sl0thentr0py
Copy link
Member Author

no if we need to revert this, we need to upgrade the ruby version of the github action (and possibly other things I haven't checked)

@st0012
Copy link
Collaborator

st0012 commented Jan 13, 2024

I see. I think changing this line should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing release on rubygems.org?
3 participants