Make sure sending_allowed? is respected irrespective of spotlight configuration

[sl0thentr0py]

we need to make a difference between the 'event building' and the 'sending' so I made this more explicit.

fixes #2226

[codecov]

Codecov Report

Merging #2231 (497a8e0) into master (213e2ab) will decrease coverage by 33.04%.
The diff coverage is 100.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #2231       +/-   ##
===========================================
- Coverage   97.61%   64.58%   -33.04%     
===========================================
  Files         112      111        -1     
  Lines        4153     4125       -28     
===========================================
- Hits         4054     2664     -1390     
- Misses         99     1461     +1362     

Components	Coverage Δ
sentry-ruby	54.29% <100.00%> (-44.04%)	⬇️
sentry-rails	95.05% <ø> (ø)
sentry-sidekiq	94.70% <ø> (ø)
sentry-resque	90.76% <ø> (ø)
sentry-delayed_job	95.60% <ø> (ø)
sentry-opentelemetry	100.00% <ø> (ø)

Files	Coverage Δ
sentry-ruby/lib/sentry/client.rb	39.80% <100.00%> (-60.20%)	⬇️
sentry-ruby/lib/sentry/configuration.rb	80.00% <100.00%> (-18.80%)	⬇️

... and 62 files with indirect coverage changes

[sandstrom]

Just curious, is this something that will be merged soon?

We've tried out Spotlight, but with this bug it's also caused all dev events to flow from developer machines to Sentry, with no easy way to turn it off.

Would be great for us if this could be merged!

cc @sl0thentr0py @st0012

[sl0thentr0py]

sorry slipped through the cracks

[szokeasaurusrex]

stamp