Only instantiate SessionFlusher when the SDK is enabled under the current env #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method aims to encapsulate the conditions we need to consider for enabling session tracking. Currently, it includes: - Whether the auto_session_tracking option is enabled - Whether the SDK is enabled under the current environment
st0012
changed the title
Configuration#session_tracking
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2245 +/- ##
===========================================
+ Coverage 66.46% 97.43% +30.97%
===========================================
Files 101 102 +1
Lines 3793 3825 +32
===========================================
+ Hits 2521 3727 +1206
+ Misses 1272 98 -1174
|
sl0thentr0py
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method aims to encapsulate the conditions we need to consider for enabling session tracking. Currently, it includes:
Closes #2234