Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backtrace parsing regexp to support Ruby 3.4 #2252

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Feb 21, 2024

In Ruby 3.4, the backtrace format has changed slightly. This commit updates the regular expression used to parse the backtrace to support Ruby 3.4.

See ruby/ruby#9608 for more information.

(This is required to keep the CI green)

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Merging #2252 (5fcddb4) into master (27128d6) will increase coverage by 30.96%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2252       +/-   ##
===========================================
+ Coverage   66.44%   97.41%   +30.96%     
===========================================
  Files         101      102        +1     
  Lines        3797     3828       +31     
===========================================
+ Hits         2523     3729     +1206     
+ Misses       1274       99     -1175     
Components Coverage Δ
sentry-ruby 98.14% <100.00%> (+42.50%) ⬆️
sentry-rails 95.05% <ø> (ø)
sentry-sidekiq 94.70% <ø> (ø)
sentry-resque 90.76% <ø> (ø)
sentry-delayed_job 95.60% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/backtrace.rb 96.66% <100.00%> (+55.98%) ⬆️

... and 53 files with indirect coverage changes

In Ruby 3.4, the backtrace format has changed slightly. This commit
updates the regular expression used to parse the backtrace to support
Ruby 3.4.

See ruby/ruby#9608 for more information.
@st0012 st0012 force-pushed the update-ci-for-ruby-3.4 branch from 907eb47 to 0f2d84b Compare February 21, 2024 11:03
@st0012 st0012 requested a review from sl0thentr0py February 21, 2024 11:12
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice thx

@st0012 st0012 merged commit 478c4cf into master Feb 21, 2024
124 checks passed
@st0012 st0012 deleted the update-ci-for-ruby-3.4 branch February 21, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants