Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate client report and rate limit handling with data categories #2294

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

sl0thentr0py
Copy link
Member

needed to clean up some logic for metrics client reports and rate limiting

@sl0thentr0py sl0thentr0py force-pushed the neel/data-category-unify branch from 4283479 to e207f0c Compare April 11, 2024 13:48
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Merging #2294 (abe863c) into master (17959d8) will increase coverage by 0.00%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2294   +/-   ##
=======================================
  Coverage   98.69%   98.70%           
=======================================
  Files         199      200    +1     
  Lines       13152    13241   +89     
=======================================
+ Hits        12981    13070   +89     
  Misses        171      171           
Components Coverage Δ
sentry-ruby 99.09% <100.00%> (+<0.01%) ⬆️
sentry-rails 97.33% <ø> (ø)
sentry-sidekiq 96.98% <ø> (ø)
sentry-resque 96.76% <ø> (ø)
sentry-delayed_job 98.91% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/client.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/envelope.rb 98.33% <100.00%> (+0.37%) ⬆️
sentry-ruby/lib/sentry/transport.rb 99.04% <100.00%> (-0.04%) ⬇️
...ntry-ruby/spec/sentry/client/event_sending_spec.rb 99.63% <100.00%> (ø)
sentry-ruby/spec/sentry/envelope_spec.rb 100.00% <100.00%> (ø)
...try/transport/http_transport_rate_limiting_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/transport_spec.rb 100.00% <100.00%> (ø)

@sl0thentr0py sl0thentr0py force-pushed the neel/data-category-unify branch from e20799d to abe863c Compare April 11, 2024 14:14
@sl0thentr0py sl0thentr0py merged commit 0257494 into master Apr 11, 2024
124 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/data-category-unify branch April 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants