Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw error on arbitrary arguments being passed to capture_event options #2301

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

sl0thentr0py
Copy link
Member

fixes #2299

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Merging #2301 (1d1f52f) into master (0c06281) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2301   +/-   ##
=======================================
  Coverage   98.71%   98.72%           
=======================================
  Files         202      202           
  Lines       13282    13294   +12     
=======================================
+ Hits        13111    13124   +13     
+ Misses        171      170    -1     
Components Coverage Δ
sentry-ruby 99.09% <100.00%> (+<0.01%) ⬆️
sentry-rails 97.37% <ø> (ø)
sentry-sidekiq 96.98% <ø> (ø)
sentry-resque 97.08% <ø> (+0.32%) ⬆️
sentry-delayed_job 98.91% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/scope.rb 100.00% <ø> (ø)
sentry-ruby/spec/sentry/scope_spec.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit 07aaf5e into master Apr 23, 2024
123 of 124 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-scope-update branch April 23, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extra data in examples and/or handle ** args
2 participants