Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config.capture_exception_frame_locals #2306

Open
wants to merge 3 commits into
base: 6.0-dev
Choose a base branch
from

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented May 6, 2024

It's been marked as deprecated for a while now and should be removed in the next major release.

Additional note: some TracePoint events can invalidate YJIT's optimization, which was a main concern of the current implementation around locals capturing. But at least until Ruby 3.3, the raise event we're using is NOT one of them.

@st0012 st0012 changed the title Remove the capture_exception_frame_locals configuration option Remove config.capture_exception_frame_locals May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (6.0-dev@7d86bb2). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             6.0-dev    #2306   +/-   ##
==========================================
  Coverage           ?   98.66%           
==========================================
  Files              ?      201           
  Lines              ?    13075           
  Branches           ?        0           
==========================================
  Hits               ?    12901           
  Misses             ?      174           
  Partials           ?        0           
Components Coverage Δ
sentry-ruby 99.05% <0.00%> (?)
sentry-rails 97.26% <0.00%> (?)
sentry-sidekiq 96.98% <0.00%> (?)
sentry-resque 96.76% <0.00%> (?)
sentry-delayed_job 98.91% <0.00%> (?)
sentry-opentelemetry 100.00% <0.00%> (?)
Files Coverage Δ
sentry-rails/spec/dummy/test_rails_app/app.rb 92.64% <100.00%> (ø)
sentry-ruby/lib/sentry/configuration.rb 98.75% <ø> (ø)
sentry-ruby/spec/sentry/configuration_spec.rb 100.00% <ø> (ø)

st0012 added 2 commits May 6, 2024 19:09
It's been marked as deprecated for a while now and should be removed
in the next major release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant