Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+= instead of << #2317

Merged
merged 1 commit into from
Jun 6, 2024
Merged

+= instead of << #2317

merged 1 commit into from
Jun 6, 2024

Conversation

Vagab
Copy link
Contributor

@Vagab Vagab commented Jun 3, 2024

comment

Description

Describe your changes:
this pr creates a copy instead of mutating the original, which fixes the issue and my company's test suite

@Vagab
Copy link
Contributor Author

Vagab commented Jun 6, 2024

@sl0thentr0py I'm not sure who to tag for a review but wanted to get some eyes on this since it's blocking our upgrade to sentry 1.17

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.09%. Comparing base (7b00b25) to head (d628506).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2317      +/-   ##
==========================================
- Coverage   98.66%   97.09%   -1.57%     
==========================================
  Files         205      175      -30     
  Lines       13422    11756    -1666     
==========================================
- Hits        13243    11415    -1828     
- Misses        179      341     +162     
Components Coverage Δ
sentry-ruby 99.03% <100.00%> (ø)
sentry-rails 45.70% <ø> (-51.73%) ⬇️
sentry-sidekiq 96.98% <ø> (ø)
sentry-resque 96.76% <ø> (ø)
sentry-delayed_job 98.91% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/test_helper.rb 100.00% <100.00%> (ø)

... and 43 files with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit bcf8827 into getsentry:master Jun 6, 2024
117 of 123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants