Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use array for transaction names and sources on scope #2324

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

sl0thentr0py
Copy link
Member

closes #2257

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-tx-name-mem branch from 0cb799e to bc80b5f Compare June 24, 2024 13:53
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (cfc2570) to head (55e87b8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2324      +/-   ##
==========================================
- Coverage   98.68%   98.66%   -0.02%     
==========================================
  Files         205      205              
  Lines       13486    13481       -5     
==========================================
- Hits        13308    13301       -7     
- Misses        178      180       +2     
Components Coverage Δ
sentry-ruby 99.03% <100.00%> (-0.02%) ⬇️
sentry-rails 97.41% <ø> (ø)
sentry-sidekiq 97.01% <ø> (ø)
sentry-resque 96.79% <ø> (-0.33%) ⬇️
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-ruby/lib/sentry/scope.rb 100.00% <100.00%> (ø)
...y-ruby/spec/sentry/rack/capture_exceptions_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/scope/setters_spec.rb 97.58% <100.00%> (ø)
sentry-ruby/spec/sentry/scope_spec.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-tx-name-mem branch from bc80b5f to 55e87b8 Compare June 24, 2024 16:11
@sl0thentr0py sl0thentr0py merged commit 5c50c80 into master Jun 24, 2024
123 of 124 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-tx-name-mem branch June 24, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry::Scope#set_transaction_name leaks memory
2 participants