-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for tracing Faraday requests #2345
Support for tracing Faraday requests #2345
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2345 +/- ##
==========================================
+ Coverage 98.66% 98.68% +0.01%
==========================================
Files 205 207 +2
Lines 13559 13741 +182
==========================================
+ Hits 13378 13560 +182
Misses 181 181
|
looks great so far! as you noted in the description, you need to further
|
bab2bac
to
295cf2e
Compare
@sl0thentr0py http patch is one of the default ones, which means we should skip setting up faraday patch if its adapter is net/http - does this make sense? |
@solnic yes please! |
fe10b09
to
14e3e1d
Compare
14e3e1d
to
037e5cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great first PR @solnic!
just a few nits and comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, ty and grats on landing your first PR!
Ahh yes! Thanks for the reviews! |
This adds support for automatic tracing of HTTP requests when using Faraday. It leverages its instrumentation middleware to do the magic.
Todo
Add a Sentry middleware that will set everything upturned out we needed a monkeypatch after all(optional/stretch) unify implementation between net/http MP and faraday extensionif we decide to do it, it should go to a separate PRCloses #1795