-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File/attachment uploads #2357
File/attachment uploads #2357
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2357 +/- ##
==========================================
+ Coverage 98.67% 98.70% +0.03%
==========================================
Files 208 209 +1
Lines 13748 13837 +89
==========================================
+ Hits 13566 13658 +92
+ Misses 182 179 -3
|
0b902f4
to
a3f2ba8
Compare
a3f2ba8
to
e9acf35
Compare
2985a36
to
de87c9a
Compare
de87c9a
to
03b17f9
Compare
03b17f9
to
6f67d4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of comments
@@ -5,6 +5,7 @@ | |||
- Support for tracing Faraday requests ([#2345](https://github.com/getsentry/sentry-ruby/pull/2345)) | |||
- Closes [#1795](https://github.com/getsentry/sentry-ruby/issues/1795) | |||
- Please note that the Faraday instrumentation has some limitations in case of async requests: https://github.com/lostisland/faraday/issues/1381 | |||
- Support for attachments ([#2357](https://github.com/getsentry/sentry-ruby/pull/2357)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for new features, we add a small snippet below the changelog entry that shows users how to use the new feature. So here,
Sentry.add_attachment(path: '/foo/bar.txt')
Sentry.add_attachment(filename: 'payload.json', bytes: '{"value": 42}'))
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- File/attachment uploads ([#2357](https://github.com/getsentry/sentry-ruby/pull/2357)) If none of the above apply, you can opt out of this check by adding |
This adds support for attaching files to the scope like this:
TODO
Sentry.add_attachment(**opts)
:path
optioncontent_type
automatically based onfilename
Closes #1548