Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Sentry meta tag in the layout automatically #2369

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Aug 13, 2024

Closes #2368

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (3fb9b67) to head (4f0c759).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2369      +/-   ##
==========================================
+ Coverage   98.69%   98.70%   +0.01%     
==========================================
  Files         209      209              
  Lines       13845    13861      +16     
==========================================
+ Hits        13664    13682      +18     
+ Misses        181      179       -2     
Components Coverage Δ
sentry-ruby 99.07% <ø> (+0.01%) ⬆️
sentry-rails 97.43% <100.00%> (+0.02%) ⬆️
sentry-sidekiq 97.01% <ø> (ø)
sentry-resque 96.79% <ø> (ø)
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-rails/lib/generators/sentry_generator.rb 100.00% <100.00%> (ø)
sentry-rails/spec/sentry/generator_spec.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@solnic solnic force-pushed the solnic/2368-auto-inject-meta-and-js-sdk-into-rails-root-layout-as-optional-part-of-generator branch from 3d6d8c4 to 618ad22 Compare August 13, 2024 07:49
@solnic solnic marked this pull request as ready for review August 13, 2024 08:14
@solnic solnic requested a review from sl0thentr0py August 13, 2024 08:14
@solnic solnic requested a review from sl0thentr0py August 13, 2024 12:42
@sl0thentr0py sl0thentr0py merged commit a09da50 into master Aug 13, 2024
126 checks passed
@sl0thentr0py sl0thentr0py deleted the solnic/2368-auto-inject-meta-and-js-sdk-into-rails-root-layout-as-optional-part-of-generator branch August 13, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto inject meta (and JS SDK) into rails root layout as optional part of generator
2 participants