Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactors #2392

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Minor refactors #2392

merged 2 commits into from
Sep 2, 2024

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Sep 1, 2024

I was going through the codebase to catchup on the recent changes and noticed a few nitpicky refactors that I want to make 🙂

#skip-changelog

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (5980531) to head (abf4826).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2392      +/-   ##
==========================================
- Coverage   98.68%   98.67%   -0.01%     
==========================================
  Files         210      210              
  Lines       13923    13922       -1     
==========================================
- Hits        13740    13738       -2     
- Misses        183      184       +1     
Components Coverage Δ
sentry-ruby 99.05% <100.00%> (-0.01%) ⬇️
sentry-rails 97.34% <ø> (ø)
sentry-sidekiq 97.07% <ø> (ø)
sentry-resque 96.79% <ø> (ø)
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/attachment.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/profiler.rb 99.11% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻 🙇🏻

@st0012 st0012 merged commit c3bcfa0 into master Sep 2, 2024
138 of 141 checks passed
@st0012 st0012 deleted the refactors branch September 2, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants