Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new strip_backtrace_load_path boolean config (default true) to enable disabling load path stripping #2409

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Sep 20, 2024

closes #2407

@sl0thentr0py sl0thentr0py requested a review from solnic September 20, 2024 15:38
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (05c4675) to head (4c755e3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2409   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files         210      210           
  Lines       13935    13957   +22     
=======================================
+ Hits        13752    13774   +22     
  Misses        183      183           
Components Coverage Δ
sentry-ruby 99.05% <100.00%> (+<0.01%) ⬆️
sentry-rails 97.34% <ø> (ø)
sentry-sidekiq 97.07% <ø> (ø)
sentry-resque 97.11% <ø> (ø)
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 98.84% <100.00%> (+<0.01%) ⬆️
sentry-ruby/lib/sentry/interfaces/stacktrace.rb 95.74% <100.00%> (+0.18%) ⬆️
...y-ruby/lib/sentry/interfaces/stacktrace_builder.rb 100.00% <100.00%> (ø)
.../spec/sentry/interfaces/stacktrace_builder_spec.rb 100.00% <100.00%> (ø)
...try-ruby/spec/sentry/interfaces/stacktrace_spec.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sl0thentr0py sl0thentr0py merged commit ab8361f into master Sep 20, 2024
138 of 141 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/optional-line-stripping branch September 20, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby Stack Trace Missing Gem Folder Names in Sentry Reported Paths
2 participants