Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore rubocop file in spec files #2420

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Sep 27, 2024

for #2419

#skip-changelog

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-rubocop-broken-release branch from e2836a9 to 1278754 Compare September 27, 2024 20:56
@sl0thentr0py sl0thentr0py requested a review from solnic September 27, 2024 20:57
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (d0afbe4) to head (1278754).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (d0afbe4) and HEAD (1278754). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (d0afbe4) HEAD (1278754)
6 3
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2420       +/-   ##
===========================================
- Coverage   98.67%   74.97%   -23.71%     
===========================================
  Files         210      132       -78     
  Lines       13970     6130     -7840     
===========================================
- Hits        13785     4596     -9189     
- Misses        185     1534     +1349     
Components Coverage Δ
sentry-ruby 54.74% <ø> (-44.31%) ⬇️
sentry-rails 97.34% <ø> (ø)
sentry-sidekiq ∅ <ø> (∅)
sentry-resque ∅ <ø> (∅)
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)

see 147 files with indirect coverage changes

@sl0thentr0py sl0thentr0py merged commit d96e8e1 into master Sep 27, 2024
68 of 141 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-rubocop-broken-release branch September 27, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants