Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize size limits based on envelope item type #2421

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Generalize size limits based on envelope item type #2421

merged 8 commits into from
Sep 30, 2024

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Sep 30, 2024

Closes #2413

@solnic
Fix spec file location
802c239
@solnic
Extract Envelope::Item to its own file
cd90baf
@solnic
Add Envelope::Item#size_limit
35e6a11
@solnic
Make Envelope::Item#{headers,payload} just readers
b721841 
We don't set headers and payloads after initializing an item, so these
accessors were not needed.
@solnic
Memoize Envelope::Item#type in the constructor
332a94c 
It's faster like that given that we rely on type value in multiple
places
@solnic
Memoize Envelope::Item#data_category
8964c60 
Same as with type, we rely on this value in multiple places so it makes
no sense to keep calculating it multiple times
@solnic solnic linked an issue Sep 30, 2024 that may be closed by this pull request
Generalize size limits based on envelope item type #2413
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (e6028ab) to head (0aafa71).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2421   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files         210      211    +1     
  Lines       13970    13987   +17     
=======================================
+ Hits        13786    13803   +17     
  Misses        184      184
Components Coverage Δ
sentry-ruby 99.05% <100.00%> (+0.01%) ⬆️
sentry-rails 97.34% <ø> (ø)
sentry-sidekiq 97.07% <ø> (ø)
sentry-resque 96.79% <ø> (-0.33%) ⬇️
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/envelope.rb 92.30% <100.00%> (-6.03%) ⬇️
sentry-ruby/lib/sentry/envelope/item.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/envelope/item_spec.rb 100.00% <ø> (ø)
sentry-ruby/spec/sentry/transport_spec.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@solnic solnic force-pushed the solnic/generalize-size-limits-based-on-envelope-item-type branch from 912f4e0 to ca2660f Compare September 30, 2024 11:02
@solnic solnic marked this pull request as ready for review September 30, 2024 11:02
sl0thentr0py
sl0thentr0py approved these changes Sep 30, 2024
View reviewed changes
sentry-ruby/lib/sentry/envelope.rb Outdated Show resolved Hide resolved
sentry-ruby/lib/sentry/envelope/item.rb Outdated Show resolved Hide resolved
@solnic solnic force-pushed the solnic/generalize-size-limits-based-on-envelope-item-type branch from 7621ef0 to 0aafa71 Compare September 30, 2024 12:08
@solnic solnic merged commit a070e08 into master Sep 30, 2024
140 checks passed
@solnic solnic deleted the solnic/generalize-size-limits-based-on-envelope-item-type branch September 30, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

@st0012 st0012 Awaiting requested review from st0012

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize size limits based on envelope item type
2 participants
@solnic @sl0thentr0py