Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent string freezing #2422

Merged
merged 5 commits into from
Oct 7, 2024

Fix Ruby head spec

2f5f18b
Select commit
Loading
Failed to load commit list.
Merged

Consistent string freezing #2422

Fix Ruby head spec
2f5f18b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 6, 2024 in 0s

98.66% (+0.00%) compared to 8dc3d2d

View this Pull Request on Codecov

98.66% (+0.00%) compared to 8dc3d2d

Details

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.66%. Comparing base (8dc3d2d) to head (2f5f18b).

Files with missing lines Patch % Lines
sentry-ruby/spec/sentry/client_spec.rb 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2422   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files         218      218           
  Lines       14337    14339    +2     
=======================================
+ Hits        14145    14147    +2     
  Misses        192      192           
Components Coverage Δ
sentry-ruby 99.00% <95.83%> (-0.01%) ⬇️
sentry-rails 97.34% <100.00%> (ø)
sentry-sidekiq 97.07% <100.00%> (ø)
sentry-resque 97.11% <ø> (+0.32%) ⬆️
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
sentry-delayed_job/lib/sentry-delayed_job.rb 73.33% <ø> (ø)
...elayed_job/lib/sentry/delayed_job/configuration.rb 100.00% <ø> (ø)
sentry-delayed_job/spec/sentry/delayed_job_spec.rb 100.00% <ø> (ø)
sentry-rails/app/jobs/sentry/send_event_job.rb 60.00% <ø> (ø)
sentry-rails/lib/generators/sentry_generator.rb 100.00% <ø> (ø)
sentry-rails/lib/sentry-rails.rb 100.00% <ø> (ø)
sentry-rails/lib/sentry/rails.rb 100.00% <ø> (ø)
sentry-rails/lib/sentry/rails/action_cable.rb 100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/active_job.rb 100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/background_worker.rb 100.00% <ø> (ø)
... and 123 more

... and 1 file with indirect coverage changes