Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with stopping Vernier #2429

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Oct 11, 2024

This ensures that we rely on status returned from Vernier.start_profile when setting profiler's @started value and also now Sentry::Vernier::Profiler#stop will fail gracefully when for whatever reason stopping crashed.

Fixes #2425

@solnic solnic linked an issue Oct 11, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (499cbac) to head (760804d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2429   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files         220      220           
  Lines       14450    14462   +12     
=======================================
+ Hits        14258    14270   +12     
  Misses        192      192           
Components Coverage Δ
sentry-ruby 99.01% <100.00%> (-0.01%) ⬇️
sentry-rails 97.34% <ø> (ø)
sentry-sidekiq 97.07% <ø> (ø)
sentry-resque 97.11% <ø> (+0.32%) ⬆️
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/vernier/profiler.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/vernier/profiler_spec.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@solnic solnic force-pushed the solnic/2425-vernier-profiler-sometimes-fails-with-no-profile-started-runtimeerror branch from 595efd3 to 760804d Compare October 11, 2024 10:17
@solnic solnic marked this pull request as ready for review October 11, 2024 10:17
@solnic solnic requested a review from sl0thentr0py October 11, 2024 10:17
@sl0thentr0py sl0thentr0py merged commit f3ed31e into master Oct 11, 2024
141 checks passed
@sl0thentr0py sl0thentr0py deleted the solnic/2425-vernier-profiler-sometimes-fails-with-no-profile-started-runtimeerror branch October 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vernier profiler sometimes fails with No profile started (RuntimeError)
2 participants