Reset trace and transaction for sidekiq-cron

[frederikspang]

Description

Adds a new transaciton and reset for Sidekiq cron #enque!, so that they are not forever-running traces in the web view.

Depends on #2403.

Fixes #2391

[codecov]

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.13%. Comparing base (9446a30) to head (f9bce57).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
sentry-sidekiq/lib/sentry/sidekiq/cron/job.rb	90.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2446      +/-   ##
==========================================
- Coverage   98.16%   98.13%   -0.04%     
==========================================
  Files         126      126              
  Lines        4741     4761      +20     
==========================================
+ Hits         4654     4672      +18     
- Misses         87       89       +2     

Components	Coverage Δ
sentry-ruby	98.51% <ø> (ø)
sentry-rails	97.05% <ø> (ø)
sentry-sidekiq	96.96% <90.00%> (-0.67%)	⬇️
sentry-resque	92.85% <ø> (ø)
sentry-delayed_job	95.65% <ø> (ø)
sentry-opentelemetry	99.31% <ø> (ø)

Files with missing lines	Coverage Δ
sentry-sidekiq/lib/sentry/sidekiq/cron/job.rb	94.59% <90.00%> (-5.41%)	⬇️

[frederikspang]

@solnic Any ideas or input for the define_method I've done?
I don't love it- But I also don't love the idea of identical method like

if Version >= 2
  def enqueue!
    ... 
  end
else
  def enque!
    ...
  end
end

with the exact same content of the two methods.

[solnic]

Some small things to improve/simplify :)

[frederikspang]

Some small things to improve/simplify :)

Replied to some, and adjusted for others! @solnic

[solnic]

Hmm, it doesn't seem to be fixing the issue though :(

[frederikspang]

@solnic That's weird...
I've tried this on our own sentry instance as well, that seems to be working.

Let me just validate tomorrow, and see what might go wrong.
Could be related to the define_method refactoring after latest PR feedback.

[frederikspang]

@solnic Are you on latest commit?

I've just tried this here, and my cron jobs look like this (Just from the traces view - But shows different trace ID's:

I'm not sure how to proceed debugging here.

[solnic]

@solnic Are you on latest commit?

I've just tried this here, and my cron jobs look like this (Just from the traces view - But shows different trace ID's:

OK I tried again and I no longer see this issue! 🎉

[pierrickouw]

FWIW, we have seen this kind of error with sidekiq-cron < 2.0 (1.12), the latest version of sentry-sidekiq, and active_job

WARN: NoMethodError: undefined method `perform_async' for an instance of ActiveJob::ConfiguredJob

making our cron fails.

Updating sidekiq-cron to 2.0 fixes the issue.