More detailed status report upon configuration #309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting thrown off by the "ready to catch errors" message that was popping up even in environments where it was configured not to send. My use case is that I have a Raven.configure block in my code all the time, but whether or not I actually enable capture is controlled the presence/absence of the SENTRY_DSN env var. Since calling Raven.capture triggers the message, it came up every time regardless of whether I was actually capturing errors.
(I know this is a somewhat superficial PR, sorry!)
Two points open for debate (besides whether or not this PR is desired/worthwhile at all) are the actual text used to indicate that errors will not be sent, and whether or not to alias report_status with report_ready, for backwards compatibility purposes. Technically report_ready is part of the public API, so even tho its doubtful that anyone was using it directly, better safe than sorry I suppose. Another option is just leaving it named report_ready, but that seems marginally less correct.
Cheers!