Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture exceptions in runner tasks #339

Merged
merged 1 commit into from
May 16, 2015

Conversation

eugeneius
Copy link
Contributor

Fixes #325.

Install Raven's at_exit hook whenever rails runner is invoked so that if an exception occurs during the task it will be reported.

I'm not really sure how to write a good test for this, but from manual testing it seems to work.

Install Raven's at_exit hook whenever rails runner is invoked so that
if an exception occurs during the task it will be reported.
@eugeneius eugeneius force-pushed the rails_runner_hook branch from c615574 to b4d08bc Compare May 16, 2015 21:04
@nateberkopec
Copy link
Contributor

boom

That's the second time I've forgotten about the at_exit hook.

nateberkopec added a commit that referenced this pull request May 16, 2015
Capture exceptions in runner tasks

Fix #325.
@nateberkopec nateberkopec merged commit d25182d into getsentry:master May 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry doesn't seem to be recording errors when started via Rails runner
2 participants