Logger can take in exceptions so stringify first #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halkeye
force-pushed
the
logging-exception-breadcrumbs
branch
from
704c1c8 to
ff84c32
Compare
|
I think the failure doesn't have anything to do with the change. BTW the link you posted is broken. |
|
I agree master has the same errors. I think my link has a extra slash in it https://ruby-doc.org/stdlib-2.5.0/libdoc/logger/rdoc/Logger.html#method-i-add-label-Args |
|
Yea that works |
|
Thx! |
|
Awesome. Now to wait for a release. Thanks so much |
|
Just to make sure, is this blocking anything? |
|
It's blocking us from using the logger breadcrumb feature. Since we have some.legacy code just logging the exception directly |
|
@halkeye Releaseing it now :) |
This was referenced Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://ruby-doc.org/stdlib-2.5.0/libdoc/logger/rdoc/Logger.html\#method-i-add-label-Args