Bump faraday version to latest #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksylvest
force-pushed
the
bump-faraday-from-v0.7.6-to-v1.0.0
branch
from
afc070d to
4f20523
Compare
Bumping required faraday version to v1.0.0 from v0.7.6. This requires dropping support for Ruby 2.2 - but fixes Ruby 2.7. For details see: https://github.com/lostisland/faraday/blob/master/CHANGELOG.md#v10
ksylvest
force-pushed
the
bump-faraday-from-v0.7.6-to-v1.0.0
branch
from
4f20523 to
eddd379
Compare
Closed
|
@HazAT, do you think that this is ready to merge? |
|
Thanks for the PR, can you add ruby 2.7 to the matrix plz? |
ksylvest
force-pushed
the
bump-faraday-from-v0.7.6-to-v1.0.0
branch
from
2fe3e95 to
eddd379
Compare
|
@HazAT not easily: 2fe3e95 (similar to how HEAD is failing in master right now). Have an issue that hasn't been responded to for this: It looks like the behaviour of JSON changed slightly between v2.6.5 and v2.7.0. I'd prefer to fix the testing of JSON in the standard library separate from bumping faraday versions if possible. |
|
OK, I am merging this but I want to wait with a release until we fixed |
|
any ETA for new gem version release with this PR? |
|
Any updates on a release? |
|
We will do a release next week, after merging: #952 |
|
@HazAT Can you confirm the release day? I got problems with the old |
|
Released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping required faraday version to v1.0.0 from v0.7.6. This requires dropping support for Ruby 2.2 - but fixes Ruby 2.7. For details see:
https://github.com/lostisland/faraday/blob/master/CHANGELOG.md#v10