Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.cargo_vcs_info.json not included in packaged crates #374

Closed
Jake-Shadle opened this issue Oct 21, 2021 · 1 comment · Fixed by #378
Closed

.cargo_vcs_info.json not included in packaged crates #374

Jake-Shadle opened this issue Oct 21, 2021 · 1 comment · Fixed by #378

Comments

@Jake-Shadle
Copy link
Contributor

When publishing crates via cargo, it will attempt to embed .cargo_vcs_info.json in to the package so that one can retrieve info about the exact revision a release was made from in the repository the package was built from, however, this file is not present in any of the packages in this repository. I'm guessing this is due to the use of the --allow-dirty flag in the release process due to copying the README in to each package based on a cursory glance of the release workflow.

This is related to #373, as my fallback when a license is not part of the packaged crate is to attempt to look up the LICENSE file from the repo, but to ensure it is valid I use the commit that's part of the package to ensure the LICENSE is correct at the exact point in time the release was made, but this method doesn't work on any of the sentry crates.

@Swatinem
Copy link
Member

The problem is rather that we rely on cargo-hack to publish because we have circular dev-dependencies.
Essentially rust-lang/cargo#4242 is blocking this. But I see that there might be ways to work around that, similar to the way rust-lang/futures-rs#2305 was solved. I will try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants