Remove version from path dev-dependencies to make it easier to publish #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exrook
pushed a commit
to exrook/futures-rs
that referenced
this pull request
Apr 5, 2021
4 tasks
Dunqing
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Jul 23, 2024
1. This looks like caused by rust-lang/cargo#4242 ## Ref 1. rust-lang/futures-rs#2305
DonIsaac
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Jul 23, 2024
1. This looks like caused by rust-lang/cargo#4242 1. rust-lang/futures-rs#2305
DonIsaac
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Jul 24, 2024
1. This looks like caused by rust-lang/cargo#4242 1. rust-lang/futures-rs#2305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.40 (rust-lang/cargo#7333), cargo will strip dev-dependencies that don't have a version.
This removes the need to manually strip dev-dependencies when publishing a crate that has circular dev-dependencies. (i.e., this works as a workaround of rust-lang/cargo#4242)
I recently confirmed in pin-project(-internal) that this works: taiki-e/pin-project@8525d86, https://crates.io/crates/pin-project-internal/1.0.3
FYI @cramertj @Nemo157
FYI #2025